Skip to content

chore(deps): bump very_good_analysis from 6.0.0 to 7.0.0 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
include: package:very_good_analysis/analysis_options.6.0.0.yaml
include: package:very_good_analysis/analysis_options.7.0.0.yaml
2 changes: 1 addition & 1 deletion lib/mockingjay.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/// A package that makes it easy to mock, test and verify
/// navigation calls in Flutter.
library mockingjay;
library;

export 'package:mocktail/mocktail.dart';

Expand Down
3 changes: 2 additions & 1 deletion lib/src/matchers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Matcher isRoute<T extends Object?>({
}) {
// Remove once `named` argument is removed.
if (whereName == null && named != null) {
// Reassigning it to the parameter to make the code flow nicer.
// ignore: parameter_assignments
whereName = equals(named);
}
Expand Down Expand Up @@ -94,7 +95,7 @@ class _RouteMatcher<T> extends Matcher {
hasMaintainStateMatcher ||
hasFullscreenDialogMatcher;

/// Takes an [input] string that looks like "FooBarRoute<MyType>" and extracts
/// Takes an [input] string that looks like `FooBarRoute<MyType>` and extracts
/// the part "MyType".
///
/// If the `Route<` part cannot be found, it returns the input string
Expand Down
2 changes: 1 addition & 1 deletion lib/src/mock_navigator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class _MockMaterialPageRoute extends MaterialPageRoute<void> {
// By the time the setState is called, the attribute is already set
// so we just ignore the error and the hack will do its job.
state.insert(entry);
} catch (_) {}
} on Object catch (_) {}
// Set mounted back to false to make sure the state doesn't get
// marked as dirty during OverlayEntry.remove().
state._mounted = false;
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ dependencies:
test: ^1.25.7

dev_dependencies:
very_good_analysis: ^6.0.0
very_good_analysis: ^7.0.0
2 changes: 2 additions & 0 deletions test/src/matchers_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,11 @@ void main() {
group('constructor', () {
test('wraps deprecated name value in equals matcher', () {
expect(
// Specifically testing deprecated member here
// ignore: deprecated_member_use_from_same_package
isRoute(named: '/test'),
isA<dynamic>().having(
// Expecting Dynamic here
// ignore: avoid_dynamic_calls
(dynamic m) => m.whereName,
'whereName',
Expand Down
Loading