Fix various event and promise issues, especially timing #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: * Mark finished promises as handled. * Change when currentchange fires slightly, so that currentchange handlers can't cause microtasks to run at an unusual time and thus swap the usual ordering of events and promises. This also allows us to clean up the "did finish before commit" bit since, contrary to the note in the spec, it was actually only necessary because of the currentchange-triggers-microtasks problem. * Always "wait for all" on at least one promise, since the zero-promise special case causes timing changes. Closes #199. This corresponds to the Chromium change in https://chromium-review.googlesource.com/c/chromium/src/+/3405377.
domenic
force-pushed
the
fix-ordering-issues
branch
from
176d62c to
ce8cc00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
Mark finished promises as handled.
Change when currentchange fires slightly, so that currentchange handlers can't cause microtasks to run at an unusual time and thus swap the usual ordering of events and promises. This also allows us to clean up the "did finish before commit" bit since, contrary to the note in the spec, it was actually only necessary because of the currentchange-triggers-microtasks problem.
Always "wait for all" on at least one promise, since the zero-promise special case causes timing changes.
Closes #199.
This corresponds to the Chromium change in https://chromium-review.googlesource.com/c/chromium/src/+/3413934.
This currently depends on whatwg/webidl#1090 which will hopefully be merged soon; the build won't pass without that.
Preview | Diff