Skip to content

Add table64 lowering pass #6595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2024
Merged

Add table64 lowering pass #6595

merged 3 commits into from
May 15, 2024

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented May 15, 2024

This needs to land before I can update llvm: llvm/llvm-project#92042

@sbc100
Copy link
Member Author

sbc100 commented May 15, 2024

Updated. And with feedback in a separate commit!

@sbc100 sbc100 requested a review from kripken May 15, 2024 18:45
@sbc100
Copy link
Member Author

sbc100 commented May 15, 2024

Any idea whats up with the tsan failure. It doesn't look related:

n file included from /home/runner/work/binaryen/binaryen/src/passes/StringLowering.cpp:33:
124
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/algorithm:61:
125
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_algo.h:61:
126
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_tempbuf.h:263:8: error: 'get_temporary_buffer<std::unique_ptr<wasm::Global>>' is deprecated [-Werror,-Wdeprecated-declarations]
127
  263 |                 std::get_temporary_buffer<value_type>(_M_original_len));
128
      |                      ^
129
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_algo.h:4996:15: note: in instantiation of member function 'std::_Temporary_buffer<__gnu_cxx::__normal_iterator<std::unique_ptr<wasm::Global> *, std::vector<std::unique_ptr<wasm::Global>>>, std::unique_ptr<wasm::Global>>::_Temporary_buffer' requested here
130
 4996 |       _TmpBuf __buf(__first, (__last - __first + 1) / 2);
131
      |               ^
132
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_algo.h:5070:23: note: in instantiation of function template specialization 'std::__stable_sort<__gnu_cxx::__normal_iterator<std::unique_ptr<wasm::Global> *, std::vector<std::unique_ptr<wasm::Global>>>, __gnu_cxx::__ops::_Iter_comp_iter<(lambda at /home/runner/work/binaryen/binaryen/src/passes/StringLowering.cpp:174:7)>>' requested here
133
 5070 |       _GLIBCXX_STD_A::__stable_sort(__first, __last,
134
      |                       ^
135
/home/runner/work/binaryen/binaryen/src/passes/StringLowering.cpp:171:10: note: in instantiation of function template specialization 'std::stable_sort<__gnu_cxx::__normal_iterator<std::unique_ptr<wasm::Global> *, std::vector<std::unique_ptr<wasm::Global>>>, (lambda at /home/runner/work/binaryen/binaryen/src/passes/StringLowering.cpp:174:7)>' requested here
136
  171 |     std::stable_sort(
137
      |          ^
138
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_tempbuf.h:99:5: note: 'get_temporary_buffer<std::unique_ptr<wasm::Global>>' has been explicitly marked deprecated here
139
   99 |     _GLIBCXX17_DEPRECATED
140
      |     ^
141
/usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/c++config.h:119:34: note: expanded from macro '_GLIBCXX17_DEPRECATED'
142
  119 | # define _GLIBCXX17_DEPRECATED [[__deprecated__]]
143
      |                                  ^
144
1 error generated.

@sbc100
Copy link
Member Author

sbc100 commented May 15, 2024

The tsan and asan failure apprear to be issues that also exist in main.. so I'm tempted land this despite them.

@tlively
Copy link
Member

tlively commented May 15, 2024

Yeah, looks like something on the runners changed. I think landing this is fine.

sbc100 added 3 commits May 15, 2024 12:36
Changes to wasm-validator.cpp here are mostly for consistency between
elem and data segment validation.
@sbc100 sbc100 force-pushed the table64_lowering branch from 23597a0 to e30b0e8 Compare May 15, 2024 19:39
@sbc100 sbc100 merged commit 2b60f8a into main May 15, 2024
11 of 13 checks passed
@sbc100 sbc100 deleted the table64_lowering branch May 15, 2024 19:53
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants