[Outlining] Improve logging #7464
Merged
+118
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Apr 7, 2025
tlively
reviewed
Apr 8, 2025
src/passes/Outlining.cpp
Outdated
Comment on lines
415
to
416
| stringify.exprs[seqIdx + substring.Length - 1]->type == | ||
| Type::unreachable, |
There was a problem hiding this comment.
The duplication here creates risk that these non-trivial arguments get out of sync in the debug and non-debug versions. Can you either create a separate variable for them or restrict the scope of the ifdef?
There was a problem hiding this comment.
okay i restricted the scope.
tlively
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the quality of debug logs during outlining by: