-
Notifications
You must be signed in to change notification settings - Fork 196
lime1 #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
lime1 #527
Conversation
Should we have the wasi target default to lime1 instead? |
it's a valid solution. my feeling is it's app developers' choice which set of features it targets to though. the intention of this PR is "do not enable extra features we ourselves (eg. libc) doesn't benefit from". |
Up to a point this is true, but we also what sensible defaults. Developers who want to target specs older than out defaults can/should be asked to rebuild libc themselves, right? My understanding was the lime1 was specifically designed as a sensible subset of
extended-const does benefit shared library builds (it allows data segments to express their offset without extra startup code). |
honestly speaking, i don't understand why "generic" and wasi should have different defaults.
it's true. |
Could you comment on the practical impact of this change? Which features in the wasi-libc build are you looking to disable? Or is there some other purpose here? |
reference-types makes some environment unhappy. |
cf. #525