Add TodoMVC for dart2js & dart2wasm #502
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a Jaspr Dart Web application compiled with dart2js and
dart2wasm.
The source is from [0] and was compiled with a modified Jaspr CLI tool
(see PR in [1]) using the following commands:
```
% rm -rf build
% dart run --resident <jaspr>/packages/jaspr_cli/bin/jaspr.dart build -O4 --extra-js-compiler-option=--no-minify
```
```
% rm -rf build
% dart run --resident <jaspr>/packages/jaspr_cli/bin/jaspr.dart build -O4 --extra-wasm-compiler-option=--no-strip-wasm --experimental-wasm
```
The relevant files in `build/jaspr/*` were copied to the Speedometer
benchmark folders.
Used Dart SDK version is: 3.8.0-edge.4c8aedcb57fe678e6d30acfdc021aa9888576638
Before landing we should figure out:
* do we want both dart2js and dart2wasm?
* do we want -O2 or -O4?
* can we rely on `js-string` builtin to be evailable or not?
[0] https://github.com/mkustermann/todomvc
[1] schultek/jaspr#397
✅ Deploy Preview for webkit-speedometer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
camillobruni
reviewed
Apr 9, 2025
| Suites.push({ | ||
| name: "TodoMVC-Dart2JS", | ||
| url: "resources/todomvc/dart2js-jaspr/index.html", | ||
| tags: ["todomvc"], |
There was a problem hiding this comment.
they both should have the experimental tag set, and should be have disabled: true,
|
now that we have 3.1 release... let me try to answer some questions :).
Would it be possible to get the build script as part of the PR? This way we can get this re-generated easier in the future. |
|
As for the js-strings builtins, given that safari doesn't ship it yet we could evaluate the polyfill and/or provide a version without the js-strings as comparison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Jaspr Dart Web application compiled with dart2js and dart2wasm.
The source is from [0] and was compiled with a modified Jaspr CLI tool (see PR in [1]) using the following commands:
The relevant files in
build/jaspr/*were copied to the Speedometer benchmark folders.Used Dart SDK version is: 3.8.0-edge.4c8aedcb57fe678e6d30acfdc021aa9888576638
Before landing we should figure out:
[0] https://github.com/mkustermann/todomvc
[1] schultek/jaspr#397