Implement messageerror event #6654

cdumez · 2022-11-18T22:52:25Z

`5e2beb5`

Implement messageerror event
https://bugs.webkit.org/show_bug.cgi?id=171216
rdar://96467919

Reviewed by Darin Adler.

Implement messageerror event:
- whatwg/html#2530

Previously, WebKit would fire a `message` event with its `data` being null,
whenever data deserialization would fail. This wasn't as per specification and
did not match other browser engines. We're supposed to fire a `messageerror`
event instead.

This patch addresses the issue.

* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-windowless-body-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/broadcastchannel-success-and-failure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/window-sharedworker-failure-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webmessaging/messageerror-expected.txt:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
* Source/WebCore/bindings/js/SerializedScriptValue.h:
* Source/WebCore/dom/BroadcastChannel.cpp:
(WebCore::BroadcastChannel::dispatchMessage):
* Source/WebCore/dom/MessageEvent.cpp:
(WebCore::MessageEvent::create):
* Source/WebCore/dom/MessageEvent.h:
* Source/WebCore/dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
* Source/WebCore/dom/MessagePort.idl:
* Source/WebCore/html/HTMLAttributeNames.in:
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage):
* Source/WebCore/page/WindowEventHandlers.idl:
* Source/WebCore/workers/DedicatedWorkerGlobalScope.idl:
* Source/WebCore/workers/Worker.idl:
* Source/WebCore/workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
* Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::startMessages):
(WebCore::ServiceWorkerContainer::postMessage):
* Source/WebCore/workers/service/ServiceWorkerContainer.h:
* Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::fireMessageEvent):

Canonical link: https://commits.webkit.org/256896@main

904a8fd

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-18T22:52:48Z

EWS run on current version of this PR (hash 68cc200)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-18T22:53:17Z

EWS run on previous version of this PR (hash 68cc200)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2~~
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-19T03:55:06Z

EWS run on previous version of this PR (hash cc31a22)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T03:57:15Z

EWS run on previous version of this PR (hash cc31a22)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-19T18:39:38Z

EWS run on current version of this PR (hash 904a8fd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	⏳ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	⏳ 🧪 api-mac	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-19T18:41:27Z

Starting EWS tests for 904a8fd. Live statuses available at the PR page, #6654

webkit-early-warning-system · 2022-11-19T18:41:28Z

EWS run on current version of this PR (hash 904a8fd)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

darinadler

Code seems slightly repetitive. I might suggest some helpers so the different flavors of postMessage and dispatchMessage can share more, but not sure if that would be good in practice.

https://bugs.webkit.org/show_bug.cgi?id=171216 rdar://96467919 Reviewed by Darin Adler. Implement messageerror event: - whatwg/html#2530 Previously, WebKit would fire a `message` event with its `data` being null, whenever data deserialization would fail. This wasn't as per specification and did not match other browser engines. We're supposed to fire a `messageerror` event instead. This patch addresses the issue. * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-windowless-body-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/broadcastchannel-success-and-failure-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/wasm/serialization/module/window-sharedworker-failure-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webmessaging/messageerror-expected.txt: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserialize): * Source/WebCore/bindings/js/SerializedScriptValue.h: * Source/WebCore/dom/BroadcastChannel.cpp: (WebCore::BroadcastChannel::dispatchMessage): * Source/WebCore/dom/MessageEvent.cpp: (WebCore::MessageEvent::create): * Source/WebCore/dom/MessageEvent.h: * Source/WebCore/dom/MessagePort.cpp: (WebCore::MessagePort::dispatchMessages): * Source/WebCore/dom/MessagePort.idl: * Source/WebCore/html/HTMLAttributeNames.in: * Source/WebCore/page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): * Source/WebCore/page/WindowEventHandlers.idl: * Source/WebCore/workers/DedicatedWorkerGlobalScope.idl: * Source/WebCore/workers/Worker.idl: * Source/WebCore/workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope): * Source/WebCore/workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::startMessages): (WebCore::ServiceWorkerContainer::postMessage): * Source/WebCore/workers/service/ServiceWorkerContainer.h: * Source/WebCore/workers/service/context/ServiceWorkerThread.cpp: (WebCore::fireMessageEvent): Canonical link: https://commits.webkit.org/256896@main

webkit-commit-queue · 2022-11-20T23:25:35Z

Committed 256896@main (5e2beb5): https://commits.webkit.org/256896@main

Reviewed commits have been landed. Closing PR #6654 and removing active labels.

cdumez self-assigned this Nov 18, 2022

cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Nov 18, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 19, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Nov 19, 2022

cdumez force-pushed the messageerror_event_support branch from 68cc200 to cc31a22 Compare November 19, 2022 03:54

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 19, 2022

cdumez removed the merging-blocked Applied to prevent a change from being merged label Nov 19, 2022

cdumez force-pushed the messageerror_event_support branch from cc31a22 to 904a8fd Compare November 19, 2022 18:39

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 19, 2022

cdumez marked this pull request as ready for review November 19, 2022 23:35

cdumez requested a review from rniwa as a code owner November 19, 2022 23:35

cdumez removed the merging-blocked Applied to prevent a change from being merged label Nov 19, 2022

cdumez requested review from darinadler, achristensen07 and geoffreygaren November 19, 2022 23:36

darinadler approved these changes Nov 20, 2022

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 20, 2022

cdumez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 20, 2022

webkit-early-warning-system force-pushed the messageerror_event_support branch from 904a8fd to 5e2beb5 Compare November 20, 2022 23:25

webkit-early-warning-system merged commit 5e2beb5 into WebKit:main Nov 20, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement messageerror event #6654

Implement messageerror event #6654

Uh oh!

cdumez commented Nov 18, 2022 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Nov 18, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Nov 18, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Nov 19, 2022

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading

Uh oh!

darinadler left a comment

Uh oh!

webkit-commit-queue commented Nov 20, 2022

Uh oh!

Uh oh!

Implement messageerror event #6654

Implement messageerror event #6654

Uh oh!

Conversation

cdumez commented Nov 18, 2022 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

5e2beb5

Uh oh!

webkit-early-warning-system commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 19, 2022

Uh oh!

webkit-early-warning-system commented Nov 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darinadler left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-commit-queue commented Nov 20, 2022

Uh oh!

Uh oh!

cdumez commented Nov 18, 2022 •

edited by webkit-early-warning-system

Loading

`5e2beb5`

webkit-early-warning-system commented Nov 18, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 18, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 19, 2022 •

edited

Loading