device: optimize Peer.String even more so #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name old time/op new time/op delta PeerString-8 49.5ns ±17% 32.6ns ±17% -34.09% (p=0.000 n=10+10) name old alloc/op new alloc/op delta PeerString-8 24.0B ± 0% 24.0B ± 0% ~ (all equal) name old allocs/op new allocs/op delta PeerString-8 1.00 ± 0% 1.00 ± 0% ~ (all equal) Signed-off-by: Alexander Yastrebov <[email protected]>
zx2c4-bot
force-pushed
the
master
branch
7 times, most recently
from
5ba9663 to
c92064f
Compare
AlexanderYastrebov
added a commit
to AlexanderYastrebov/wireguard-go
that referenced
this pull request
May 31, 2025
I am not sure why it must be fast but there were previous efforts 25ad08a and 9087e44 to speed it up; and I even did my own WireGuard#60. If that is so important lets cache peer string to make it fast and readable again. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
to AlexanderYastrebov/wireguard-go
that referenced
this pull request
May 31, 2025
I am not sure why it must be fast but there were previous efforts 25ad08a and 9087e44 to speed it up; and I even did my own WireGuard#60. If that is so important lets cache peer string to make it fast and readable again. Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Yastrebov [email protected]