Revert "Route requests for missing static files using remote asset metadata - Second attempt" #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tadata -…" This reverts commit 7549565.
brandonpayton
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1490
I'm going to revert this because people with existing browser storage are going to have issues if /wordpress/wordpress-remote-asset-paths is not found. That was clear when this was originally reverted, but I focused on stopping the deletion of the listing file rather than considering browser storage prior to the existence of the listing.
Tomorrow, when returning with a clearer mind, I plan to consider how we might deal with this scenario.
cc @WordPress/playground-maintainers