Throwaway PR: Try to repro and debug CI-specific test failures from #1539 #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR:
- Updates PHPRequestHandler to support custom file-not-found responses
- Updates worker-thread to configure PHPRequestHandler to handle
file-not-found conditions properly for WordPress
- Updates worker-thread to flag remote WP assets for retrieval by the
Service Worker
Prior to this PR, we could not easily tell whether we should request a
missing static asset from the web or delegate a request for a missing
file to WordPress.
Related to #1365 where we need better information to judge whether to
handle a request for a missing static file as PHP.
- CI tests
- Test manually with `npm run dev` and observe that Playground loads
normally with no unexpected errors in the console
…ecution of tests in multiple projects
brandonpayton
force-pushed
the
fix-request-routing-test-failures
branch
from
3d886a5 to
ad90d12
Compare
…allel execution of tests in multiple projects" This reverts commit cf4fe74.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate PR to allow experimentation and debugging of unexpected test failures under #1539 that cannot be reproduced locally.