[Website] Update the fake address bar via setInterval() #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ellatrix reported the URL is not getting updated when navigating through the site editor. One possible reason is the site editor uses the `history.push()` API which does not trigger the iframe load event. This PR adds a proactive polling for URL changes via a setInterval() call. ## Testing instructions 1. Open Playground 2. Go to the site editor 3. Note the path in the address bar 4. Click on the WordPress logo 5. The path should change
adamziel
added
[Type] Bug
bgrgicak
reviewed
Jun 2, 2025
| // * https://html.spec.whatwg.org/multipage/document-sequences.html#nav-active-history-entry | ||
| // * https://html.spec.whatwg.org/dev/browsing-the-web.html#centralized-modifications-of-session-history | ||
| let lastPath: string | undefined; | ||
| setInterval(async () => { |
There was a problem hiding this comment.
We should clear the interval after Playground is stopped.
Now, if you start with a temporary Playground, go to the Site Manager, and click on a Saved Playground, two interval loops will run in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ellatrix reported the URL is not getting updated when navigating through the site editor. One possible reason is the site editor uses the
history.push()API which does not trigger the iframe load event.This PR adds a proactive polling for URL changes via a setInterval() call.
Testing instructions