Live Radio stations and Youtube url to mp3 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great overall !
|
iGameCreep
reviewed
Apr 4, 2025
| const { EmbedBuilder } = require('discord.js'); | ||
| const { Translate } = require('../process_tools'); | ||
|
|
||
| module.exports = async ({ client, inter }) => { |
iGameCreep
reviewed
Apr 4, 2025
| const { Translate } = require('../process_tools'); | ||
| const { stopRadio } = require('../utils/radioPlayer'); | ||
|
|
||
| module.exports = async ({ client, inter }) => { |
| let result = false; | ||
|
|
||
| // Check if there's an active connection for this guild | ||
| if (activeConnections && activeConnections.has(inter.guild.id)) { |
There was a problem hiding this comment.
Use optional chaining (activeConnections?.has(inter.guild.id)) instead (lint)
| const { ApplicationCommandOptionType, EmbedBuilder, ActionRowBuilder, ButtonBuilder, ButtonStyle } = require('discord.js'); | ||
| const { Translate } = require('../../process_tools'); | ||
| const radioStations = require('../../radioStations'); | ||
| const { playRadioStation, stopRadio } = require('../../utils/radioPlayer'); |
|
|
||
| const defaultEmbed = new EmbedBuilder().setColor('#2f3136'); | ||
|
|
||
| // Set quality based on user selection |
There was a problem hiding this comment.
Why base quality off of volume ? Aren't these 2 different things ?
| const activeConnections = new Map(); | ||
|
|
||
| // Cache for converted URLs to avoid redundant conversions | ||
| const convertedUrlCache = new Map(); |
| player.on(AudioPlayerStatus.Idle, () => { | ||
| console.log('Radio stream ended or errored, attempting to reconnect...'); | ||
| // Try to restart the stream after a brief delay | ||
| setTimeout(() => { |
There was a problem hiding this comment.
During this loop, user is never informed of what is going on. The only sign is the log in the console, which the user doesn't see.
| // First request to get the conversion started | ||
| const response = await axios.get(`https://cnvmp3.com/v23/api/single/mp3/${videoId}`); | ||
|
|
||
| if (!response.data || !response.data.id) { |
There was a problem hiding this comment.
Optional chain would be better
| // Second request to get the download URL | ||
| const statusResponse = await axios.get(`https://cnvmp3.com/v23/api/mp3/${conversionId}`); | ||
|
|
||
| if (!statusResponse.data || !statusResponse.data.url) { |
There was a problem hiding this comment.
Same here; optional chain
| const { useMainPlayer, QueryType } = require('discord-player'); | ||
|
|
||
| // Store active YouTube connections to manage them | ||
| const activeYoutubeConnections = new Map(); |
There was a problem hiding this comment.
If you use discord-player to stream the music, then you can just stay with queues and the hooks (useQueue)
|
|
||
| // Create an audio resource from the stream | ||
| const resource = createAudioResource(streamResponse, { | ||
| inputType: StreamType.Arbitrary, |
There was a problem hiding this comment.
Shouldn't this be the value defined in the radioStations.js file ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Add Live Radio Support & YouTube to MP3 Conversion
Description:
This pull request introduces two major features to the bot:
Live Radio Support – Users can now stream live radio stations directly through the bot. Added support for various radio stream URLs.
YouTube to MP3 Conversion – Users can provide a YouTube URL, and the bot will convert and play the audio. This improves accessibility for users who prefer listening without streaming the video.
Changes & Additions:
Implemented a radio command to handle live streaming links.
Added a YouTube to MP3 converter using yt-dlp for efficient audio extraction.
Updated the help command to reflect new features.
Optimized playback handling for seamless integration of new features.
Testing & Notes:
Tested multiple radio stations for compatibility.
Ensured YouTube conversion handles common formats and errors gracefully.
Verified smooth playback transitions between different audio sources.
Looking forward to feedback! 🚀