generated from aboutcode-org/skeleton
-
Notifications
You must be signed in to change notification settings - Fork 24
Issue 180: Fix not parsing pip.conf index urls #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calizarr
wants to merge
8
commits into
aboutcode-org:main
Choose a base branch
from
calizarr:fix-180-pip-conf-parsing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e8e8387
Issue 180: Fix not parsing pip.conf index urls
calizarr 0218fc5
Fix 180: Make subprocess commands proper lists
calizarr 0f1fb7d
Fix 180: Parse environment variables as well
calizarr 4bf69cf
Fix 180: Fix typo in ternary statements
calizarr e3e6a24
Fix 180: Make sure to use pip as defined by python
calizarr 575858d
Fix 180: Add some pycodestyle changes
calizarr f7ffe07
Fix 180: Make pycodestyle even happier
calizarr a45e315
Fix 180: Remove `/usr/bin/env` since this also runs on Windows
calizarr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would assume pip is installed and available. But we cannot make this blanket assumption. We could instead call its code, extracting and vendoring the pip subset that reads the config file(s). See:
I am not comfy with spawning a subprocess to read a config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm fine with just abandoning this one since I haven't worked on it in a bit and this one solves most of the issues I had without dealing with pip.conf at the moment.