Skip to content

Merge latest skeleton with ruff #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 116 commits into
base: main
Choose a base branch
from
Open

Merge latest skeleton with ruff #211

wants to merge 116 commits into from

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Mar 31, 2025

This PR merges the latest skeleton that adds support for ruff for code linting and formatting

JonoYang and others added 30 commits July 17, 2023 13:28
Added docs server script, dark mode & copybutton for docs, tracking chmod in git
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Update CSS to widen page and handle mobile #84
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Update CI runners and python version
Replace macos-11 runners with macos-14 runners.

Reference: https://github.com/actions/runner-images?tab=readme-ov-file#available-images
Reference: aboutcode-org/skeleton#89
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Replace deprecated macos CI runners
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
    * Use ruff config and Make commands from scancode.io

Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Reference: #212
Signed-off-by: Philippe Ombredanne <[email protected]>
Remove running "make check" as a test

Signed-off-by: Philippe Ombredanne <[email protected]>
This is now part of a CI command with the latest skeleton

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This is not yet supported everywhere

Signed-off-by: Philippe Ombredanne <[email protected]>
We were missing some

Signed-off-by: Philippe Ombredanne <[email protected]>
We do not need to run all online tests on all
OSes adn Python combinations, but just once for sanity
on each OS.

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Otherwise CI test fails with pytest markers

Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Copy link
Member Author

This is about ready to merge, but is missing a CHANGELOG entry

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Instead of testing ... and update references accordingly

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Not used anymore

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
This avoid some churn from version updates

Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Copy link
Member Author

Unless there is an objection I will merge it even though we have failed tests with #215 (they also fail randomly in head and this is blocker for a new release in all cases.)

@pombredanne
Copy link
Member Author

@heliocastro FYI, this is using the skeleton, and only deals with using ruff in a minimally intrusive way.

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants