-
Notifications
You must be signed in to change notification settings - Fork 359
Use tokio-rustls 0.23 #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Re: CI failures: rustls uses bool::then which were stabilized in 1.50 (rust-lang/rust#79299). Not sure if we can bump actix-net's MSRV to 1.50? (rustls real MSRV is 1.52.1 so optimally we'd bump to that instead). |
1.52 is higher than i want to go :/ the higher level parts of actix have moved to 1.51 recently i'll look into it today |
Managed to get the CI working. Raised MSRV for -server and -tls to 1.52 so this can go ahead. |
released in actix-tls v3.0.0-beta.6 |
PR Type
Feature
PR Checklist
Check your PR fulfills the following:
Overview
This is related to actix/actix-web#2304, which requires
acitx-tls
to supportrustls
0.20.tokio-tls
0.23 adds this support, so we just need to version bump everything, and address locations that are broken.Note that a breaking change exists, as we no longer re-export
Session
.Tests were made with
cargo t --all-features
, and verification of the change was performed withcargo tree -p actix-tls --all-features | grep rustls
: