Skip to content

Update index.html with minor fixes #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.html with minor fixes #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 52 additions & 45 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
Here are some potential fixes for the HTML code provided:

1. The `<link>` tags for JavaScript files should use the `src` attribute instead of `href`.
2. The `<loading />` and `<stats />` components should use `<loading></loading>` and `<stats></stats>` respectively for proper HTML syntax.
3. Ensure that closing tags are properly formatted, especially for self-closing tags like `<img>`.
4. The `ng-class="{disabled: loading}"` should be `ng-class="{'disabled': loading}"` for proper AngularJS syntax.
5. Ensure that all URLs in the `href` and `src` attributes are correctly formatted.

Here is the corrected code:

```html
<!--
========================== Presenting Adobe GitHub Homepage v2.0 ==========================
------------------- The new central hub for Adobe Open sources projects. ------------------
Expand All @@ -20,7 +31,7 @@
-->

<!DOCTYPE html>
<!--[if IE 8]> <html class="no-js lt-ie9" lang="en" > <![endif]-->
<!--[if IE 8]> <html class="no-js lt-ie9" lang="en"> <![endif]-->
<!--[if gt IE 8]><!--> <html class="no-js" lang="en" ng-app="AdobeOpenSource"> <!--<![endif]-->

<head>
Expand All @@ -29,7 +40,7 @@
<title>Adobe Open Source | Advancing technology through open initiatives</title>
<link href="stylesheets/app.css" rel="stylesheet">
<link rel="stylesheet" href="stylesheets/clastyles.css">
<link href= "https://ajax.googleapis.com/ajax/libs/angularjs/1.7.7/angular.min.js">
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.7.7/angular.min.js"></script>
<link href="//fonts.googleapis.com/css?family=Open+Sans" rel="stylesheet">
<link href="//code.jquery.com/ui/1.10.3/themes/smoothness/jquery-ui.css" rel="stylesheet">
<link rel="shortcut icon" href="adobe.ico"/>
Expand Down Expand Up @@ -74,7 +85,7 @@
<dl class="sub-nav" ng-class="{mobile: mobile}">
<a class="menu-icon" ng-click="expandMenu()">
<span></span>
</a>
</a>

<dd class="title">
<strong>Adobe</strong> Open Source
Expand All @@ -84,7 +95,7 @@
<dd class="head-base"><a href="#statistics" ng-click="menuOpen = false">Statistics</a></dd>
<dd class="head-base"><a href="#projects" ng-click="menuOpen = false">Repositories</a></dd>
<dd class="head-base"><a href="#organizations" ng-click="menuOpen = false">Organizations</a></dd>
<dd class="head-base"><a href="cla.html"ng-click="menuOpen">CLA</a></dd>
<dd class="head-base"><a href="cla.html" ng-click="menuOpen">CLA</a></dd>
</div>
</dl>

Expand All @@ -95,7 +106,6 @@
</div>
</div>


<div id="supported">
<a class="head-anchor" name="statistics"></a>
<div class="intro">
Expand All @@ -110,10 +120,10 @@
<h4>Statistics</h4>
</div>
<div class="large-12 columns" ng-show="loading">
<loading />
<loading></loading>
</div>
<div class="large-12 columns" ng-show="!loading">
<stats projects="projects" orgs="orgs" stats="stats" langs="langs"/>
<stats projects="projects" orgs="orgs" stats="stats" langs="langs"></stats>
</div>
</div>
<div class="large-6 columns" ng-click="posLabel()">
Expand Down Expand Up @@ -174,9 +184,9 @@ <h2 class="large-6 small-4 columns">Repos</h2>
<option value="-size">Size</option>
</select>
</div>
<div class="button large-2 small-2 culumns" ng-click="toggleFiltersButton()" ng-class="{disabled: loading}">
<div class="button large-2 small-2 columns" ng-click="toggleFiltersButton()" ng-class="{'disabled': loading}">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" id="Layer_1" x="0px" y="0px" width="100px" height="100px" viewBox="0 0 100 100" enable-background="new 0 0 100 100" xml:space="preserve">
<path fill="#000000" d="M50.717,2.495c-29.288,0-47.692,6-47.692,10.833c0,5.932,16.029,19.893,20.167,23.667 c4.712,4.299,16.044,16.058,16.5,18.001c0.147,2.147,2.002,35.008,2.002,35.008s-0.168,5.5,8.998,5.5 c9.166,0,8.498-5.334,8.498-5.334s2.169-32.674,2.169-34.84s8.333-10.835,18.5-20.002c10.167-9.167,18.167-15.758,18.167-22 C98.025,8.299,80.004,2.495,50.717,2.495z M50.481,21.083C28.676,21.083,11,17.965,11,14.12s17.676-7.964,39.481-7.964 c21.801,0,39.478,4.119,39.478,7.964S72.282,21.083,50.481,21.083z"/>
<path fill="#000000" d="M50.717,2.495c-29.288,0-47.692,6-47.692,10.833c0,5.932,16.029,19.893,20.167,23.667 c4.712,4.299,16.044,16.058,16.5,18.001c0.147,2.147,2.002,35.54,2.002,35.54h18.667c0,0,1.854-33.394,2.001-35.54 c0.456-1.942,11.788-13.701,16.5-18.001c4.138-3.774,20.167-17.735,20.167-23.667C98.41,8.495,80.005,2.495,50.717,2.495z M50.717,24.495c-6.334,0-11.5-5.166-11.5-11.5s5.166-11.5,11.5-11.5s11.5,5.166,11.5,11.5S57.051,24.495,50.717,24.495z"/>
</svg>
</div>
</form>
Expand All @@ -188,20 +198,20 @@ <h2 class="large-6 small-4 columns">Repos</h2>
<div class="row">
<form class="custom large-12 columns mainFilters">
<div class="large-4 columns">
<input type="text" ng-model="searchName" placeholder="Search name, description...">
<input type="text" ng-model="searchName" placeholder="Search name, description...">
</div>

<div class="large-3 columns">
<input id="searchLang" type="text" ng-model="searchLangInput" placeholder="Languages">
<input id="searchLang" type="text" ng-model="searchLangInput" placeholder="Languages">
</div>

<div class="large-3 columns">
<input id="searchOrg" type="text" ng-model="searchOrgInput" placeholder="Organizations">
<input id="searchOrg" type="text" ng-model="searchOrgInput" placeholder="Organizations">
</div>

<div class="star large-2 columns">
<a class="button tiny cancel" ng-show="filterStarIndex" ng-click="majFilterStar(0); majDisplayStar(0)">X</a>
<div class="fitlerStar" ng-repeat="i in [1,2,3,4,5]" ng-class="{on: (i <= displayStarIndex)}" ng-click="majFilterStar(i)" ng-mouseenter="majDisplayStar(i)" ng-mouseleave="majDisplayStar(filterStarIndex)"></div>
<div class="filterStar" ng-repeat="i in [1,2,3,4,5]" ng-class="{on: (i <= displayStarIndex)}" ng-click="majFilterStar(i)" ng-mouseenter="majDisplayStar(i)" ng-mouseleave="majDisplayStar(filterStarIndex)"></div>
</div>
</form>

Expand All @@ -223,14 +233,14 @@ <h2 class="large-6 small-4 columns">Repos</h2>
<!-- ------- Items -------- -->
<div class="row wrapProjects">
<div ng-show="loading">
<loading />
<loading></loading>
</div>

<div ng-show="!loading">
<div class="large-12 columns">
<div class="row">
<div class="large-6 columns listItem" ng-repeat="actProject in projects | projectsFilter:this" ng-class-odd="'clear'">
<project project="actProject" />
<project project="actProject"></project>
</div>

<!-- Reseter -->
Expand Down Expand Up @@ -289,12 +299,12 @@ <h2 class="large-6 small-4 columns">Organizations</h2>

<div class="row">
<div ng-show="loading">
<loading />
<loading></loading>
</div>

<div ng-show="!loading">
<div class="large-6 columns listItem" ng-repeat="actOrg in orgs" ng-class-odd="'clear'">
<org org="actOrg"/>
<org org="actOrg"></org>
</div>
</div>

Expand All @@ -309,9 +319,7 @@ <h2 class="large-6 small-4 columns">Organizations</h2>
<div class="row">
<div class="small-12 columns text-header text-center" id="text-header_org">
<h3><span class="title"><strong>Adobe</strong> Open Source</span><span class="next">, built with love...</span></h3>
<h5 class="details">...and with <a target="_blank" href="http://angularjs.org/" title="AngularJS">AngularJS</a>, <a target="_blank" href="http://foundation.zurb.com/" title="Foundation">Foundation</a>,<br />
<a target="_blank" href="http://pages.github.com/" title="Github Pages">Github Pages</a> and <a target="_blank" href="http://developer.github.com/v3/" title="Github API">API</a>,<br />
<a target="_blank" href="http://www.adobe.com/products/creativecloud.html" title="Adobe Creative Cloud">Adobe Creative Cloud</a>.</h5>
<h5 class="details">...and with <a target="_blank" href="http://angularjs.org/" title="AngularJS">AngularJS</a>, <a target="_blank" href="http://foundation.zurb.com/" title="Foundation">Foundation</a>, <a target="_blank" href="http://pages.github.com/" title="Github Pages">Github Pages</a> and <a target="_blank" href="http://developer.github.com/v3/" title="Github API">API</a>, <a target="_blank" href="http://www.adobe.com/products/creativecloud.html" title="Adobe Creative Cloud">Adobe Creative Cloud</a>.</h5>
</div>
<div class="small-5 columns">
<div class="logo" id="logo3">
Expand All @@ -320,33 +328,32 @@ <h5 class="details">...and with <a target="_blank" href="http://angularjs.org/"
</a>
</div>
</div>
</div>
</div>
</div>

<!-- Google Analytics -->
<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','//www.google-analytics.com/analytics.js','ga');

ga('create', 'UA-46814863-1', 'github.com');
ga('send', 'pageview');
</script>

<!--[if gte IE 10]><!-->
<script src="js/vendor/custom.modernizr.js"></script>
<script src="//use.typekit.net/gad4asz.js"></script>
<script>try{Typekit.load();}catch(e){}</script>
<script src="//code.jquery.com/jquery-1.9.1.js"></script>
<script src="//code.jquery.com/ui/1.10.3/jquery-ui.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.2.12/angular.min.js"></script>
<script src="js/vendor/angular-resource.js"></script>
<script src="js/foundation/foundation.js"></script>
<script src="js/foundation/foundation.forms.js"></script>
<script src="js/dcjs/crossfilter.min.js"></script>
<script src="js/dcjs/d3.min.js"></script>
<script src="js/dcjs/dc.min.js"></script>
<!-- Google Analytics -->
<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','//www.google-analytics.com/analytics.js','ga');

ga('create', 'UA-46814863-1', 'github.com');
ga('send', 'pageview');
</script>

<!--[if gte IE 10]><!-->
<script src="js/vendor/custom.modernizr.js"></script>
<script src="//use.typekit.net/gad4asz.js"></script>
<script>try{Typekit.load();}catch(e){}</script>
<script src="//code.jquery.com/jquery-1.9.1.js"></script>
<script src="//code.jquery.com/ui/1.10.3/jquery-ui.js"></script>
<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.2.12/angular.min.js"></script>
<script src="js/vendor/angular-resource.js"></script>
<script src="js/foundation/foundation.js"></script>
<script src="js/foundation/foundation.forms.js"></script>
<script src="js/dcjs/crossfilter.min.js"></script>
<script src="js/dcjs/dc.min.js"></script>
<!--<![endif]-->

<script src="js/script.js"></script>
Expand Down