-
Notifications
You must be signed in to change notification settings - Fork 201
build: foundational setup for S2 development #3551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
791a4b9
to
6fa35d0
Compare
14a68cf
to
f16a142
Compare
6ff7061
to
5e7cc8f
Compare
5e7cc8f
to
88f837f
Compare
867a850
to
a05b841
Compare
File metricsSummaryTotal size: 1.38 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
File change detailsaccordion
actionbar
actionbutton
actiongroup
alertbanner
alertdialog
asset
assetcard
assetlist
avatar
badge
breadcrumb
button
buttongroup
calendar
card
checkbox
clearbutton
closebutton
coachindicator
coachmark
colorarea
colorhandle
colorloupe
colorslider
colorwheel
combobox
contextualhelp
datepicker
dial
dialog
divider
dropindicator
dropzone
fieldgroup
fieldlabel
floatingactionbutton
form
helptext
icon
illustratedmessage
infieldbutton
inlinealert
link
logicbutton
menu
meter
miller
modal
opacitycheckerboard
page
pagination
picker
pickerbutton
popover
progressbar
progresscircle
radio
rating
search
sidenav
slider
splitview
statuslight
steplist
stepper
swatch
swatchgroup
switch
table
tabs
tag
taggroup
textfield
thumbnail
toast
tooltip
tray
treeview
typography
underlay
well
tokens
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
0d5bdfb
to
8637d39
Compare
a05b841
to
ebd43a3
Compare
|
||
--spectrum-progress-circle-track-border-color-over-background: var(--spectrum-transparent-white-400); | ||
--spectrum-progress-circle-fill-border-color-over-background: var(--spectrum-transparent-white-1000); | ||
|
||
/* circle unfilled border color */ | ||
--spectrum-progress-circle-track-border-color: var(--spectrum-gray-300); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate "--spectrum-progress-circle-track-border-color"
🚀 Deployed on https://pr-3551--spectrum-css.netlify.app |
c68f4e3
to
d2272ea
Compare
f3f9cf4
to
bc07e75
Compare
019bc25
to
b55512e
Compare
b55512e
to
f8cb777
Compare
#3607) Updated border-color for is-open state from `--spectrum-gray-900` to `--spectrum-gray-800`.
f8cb777
to
1cc035b
Compare
@@ -33,12 +46,22 @@ | |||
|
|||
--spectrum-infield-button-fill-justify-content: center; | |||
|
|||
--spectrum-infield-button-border-width: var(--spectrum-border-width-100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate "--spectrum-infield-button-border-width"
@@ -33,12 +46,22 @@ | |||
|
|||
--spectrum-infield-button-fill-justify-content: center; | |||
|
|||
--spectrum-infield-button-border-width: var(--spectrum-border-width-100); | |||
--spectrum-infield-button-border-color: inherit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate "--spectrum-infield-button-border-color"
--spectrum-infield-button-border-width: var(--spectrum-border-width-100); | ||
--spectrum-infield-button-border-color: inherit; | ||
|
||
--spectrum-infield-button-border-radius: var(--spectrum-corner-radius-100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate "--spectrum-infield-button-border-radius"
--spectrum-infield-button-border-color: inherit; | ||
|
||
--spectrum-infield-button-border-radius: var(--spectrum-corner-radius-100); | ||
--spectrum-infield-button-border-radius-reset: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate "--spectrum-infield-button-border-radius-reset"
--spectrum-infield-button-border-radius-reset: 0; | ||
|
||
/* Have to call these out specifically due to Express differences */ | ||
--spectrum-infield-button-stacked-top-border-radius-start-start: var(--spectrum-infield-button-border-radius-reset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate "--spectrum-infield-button-stacked-top-border-radius-start-start"
|
||
/* Have to call these out specifically due to Express differences */ | ||
--spectrum-infield-button-stacked-top-border-radius-start-start: var(--spectrum-infield-button-border-radius-reset); | ||
--spectrum-infield-button-stacked-bottom-border-radius-end-start: var(--spectrum-infield-button-border-radius-reset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate "--spectrum-infield-button-stacked-bottom-border-radius-end-start"
Description
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list