-
Notifications
You must be signed in to change notification settings - Fork 201
fix(actionbutton): reduce mod interception #3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5ca3f4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d8953bd
to
f320825
Compare
File metricsSummaryTotal size: 2.25 MB*
actionbutton
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
🚀 Deployed on https://pr-3664--spectrum-css.netlify.app |
f320825
to
66f33c0
Compare
6cd48e5
to
d214ec4
Compare
d687176
to
5ca3f4d
Compare
@@ -68,7 +66,39 @@ | |||
--spectrum-actionbutton-border-color: transparent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused custom property --spectrum-actionbutton-border-color defined
Description
This update aims to simplify
--mod-
access by ensuring local variants and states aren't hooking into those custom properties for overrides. This updates all local variants and states to override the--spectrum-actionbutton-
properties instead and adjusts the specificity to ensure no regressions in rendered results.Other changes of note:
.spectrum-ActionButton--sizeM
as unnecessary and duplicate as these styles are applied in the base class.:not()
pseudo-class in theme overrides as these selectors are more complex to remap for web component projects.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list