-
Notifications
You must be signed in to change notification settings - Fork 201
feat(swatch+swatchgroup): S2 migration #3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spectrum-two
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 343a87b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3677--spectrum-css.netlify.app |
File metricsSummaryTotal size: 1.38 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
File change detailsswatch
swatchgroup
tokens
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
ffa2cad
to
37bccbb
Compare
91c31d2
to
d0944eb
Compare
9ca18cb
to
f3f8289
Compare
59a0dc6
to
02c2cca
Compare
02c2cca
to
044c357
Compare
Description
CSS-1026
+CSS-1029
This migrates the
swatch
andswatchgroup
components to S2. Custom properties have been remapped and added per the design specification.An
Add Swatch
variant has been added with the required color tokens and the specified add UI icon.Removed custom properties
--spectrum-swatch-border-color
--spectrum-swatch-dash-icon-color
New custom properties
--spectrum-swatch-border-color-rgb
--spectrum-swatch-border-opacity
--spectrum-corner-radius-full
--spectrum-corner-radius-none
--spectrum-swatch-disabled-icon-border-opacity
--spectrum-swatch-icon-color
--spectrum-swatch-rectangle-width-multiplier
New mods
--mod-add-button-background
--mod-add-button-background-down
--mod-add-button-background-hover
--mod-add-button-background-keyboard-focus
--mod-corner-radius-full
--mod-mixed-button-background
--mod-swatch-border-color-rgb
--mod-swatch-border-opacity
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list