-
Notifications
You must be signed in to change notification settings - Fork 249
Some preparatory proofs for proving sorting+permutation is equality #2724 #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Data/List/Relation/Binary/Permutation/Setoid/Properties.agda
Outdated
Show resolved
Hide resolved
Having looked at this, and its followup, in particular lemma
If so, then I think this PR and its followup may be simplifiable via the already existing UPDATED: on closer examination, maybe this is what you have! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks.
Happy to approve, but I too have been sniped by this... would love to be able to simplify if at all possible!
_≰_ : ∀ {n} → Rel (Fin n) 0ℓ | ||
i ≰ j = ¬ (i ≤ j) | ||
|
||
_≮_ : ∀ {n} → Rel (Fin n) 0ℓ | ||
i ≮ j = ¬ (i < j) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure. If we do so then we should do everywhere in all numeric data modules, consistently. Feel free to open an issue?
src/Data/List/Relation/Binary/Permutation/Setoid/Properties.agda
Outdated
Show resolved
Hide resolved
src/Data/List/Relation/Binary/Permutation/Setoid/Properties.agda
Outdated
Show resolved
Hide resolved
Co-authored-by: jamesmckinna <[email protected]>
Yes, I think so. If it can be simplified then I'm all for that 👍 |
I'll try to review properly this week, but for now, I've just fixed two things that slipped through the net... |
I've been sniped by #2723. This is a preparatory PR for the full proof that sorting two lists that are permutations of each other result in equal lists.