Skip to content

Flash messages example #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2018

Conversation

bmwant
Copy link
Member

@bmwant bmwant commented Apr 29, 2018

Rationale

We have an issue #25 for message flashing. I'm not sure what will be the final decision on that but we can at least include the snippet to the examples for users to refer when implementing such a feature in their application.

@bmwant
Copy link
Member Author

bmwant commented Apr 29, 2018

@asvetlov @jettify do you think we can include this example to the package?

@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files           4        4           
  Lines         194      194           
  Branches       23       23           
=======================================
  Hits          186      186           
  Misses          5        5           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac26c48...35c8c0b. Read the comment docs.

@asvetlov
Copy link
Member

Thanks for the contribution.
I'm on the conference now, will review in a few days.

@bmwant
Copy link
Member Author

bmwant commented Apr 29, 2018

@asvetlov I know, listening you talk atm))

@asvetlov asvetlov merged commit 2fed537 into aio-libs:master May 2, 2018
@asvetlov
Copy link
Member

asvetlov commented May 2, 2018

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants