Skip to content

first draft of Books - Basket scenarios #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

appendixshuffle
Copy link

@appendixshuffle appendixshuffle commented Jan 18, 2023

Generally I’m trating this as a first oteration, so I tried to open topics, as much as I can for later implementations.

That’s why I’ve skipped some of scenarios, leaving empty dir’s or empty-skeleton .spec files.
I skipped also some of the refactor parts to not lose the goal of this exercise, but I left TODO comments in the code ( which nortmally im not doing msuch things - it should be tracked as a issues in repo or JIRA tasks )
Order of the next iterations is from top to down in test_plan.txt where you can find List with desc.

  • run existing tests and understand playwright config
  • explore application and create happy path scenario ( Basket )
  • create notes regarding : refactoring, improvements of exisitng code
  • create test plan for scope of automation - next steps

Few things discovered during this exercise :

  • Im not sure what about the linter - normally im using common linter inside the repo, so my suggestion woukld bve to discuss about it and decide
  • global setup containing getters and setters for environment setu : https://playwright.dev/docs/api/class-testconfig#test-config-global-setup
  • If its monorepo for all the tests then It is good to consider to add configuration structure based on countries with usage of ‘projects:’ key : https://playwright.dev/docs/test-advanced#configuration-object and the second link : https://playwright.dev/docs/test-advanced#projects
    - Tagging tests would be usefull to implement in the beginning : https://playwright.dev/docs/test-annotations#tag-tests
  • Im having problems with absoulte paths which are not working with the default playwright config - it requires custom tsconfig.json ( im leaving it to the discussion as a propsition ) : https://playwright.dev/docs/test-typescript#tsconfigjson
  • Some of HTML attributes are : 'data-tam’ and some ‘data-testid’ - it would be good to clarify and agrre on one only. 
  • During exploration I’ve found some dialogue window with some kind of satisfaction survey , but I wasnt able to reproduce it again…needs further info and investigation
  • There is a problem with”Apply” button (diualog-oveerlay), which is covered by another layer - should be fixed by : 
    • fixing html structure, to make the button clickable 
    • add data- attribute on element which is covering that one 
  • Add proper README

Marek_Rukat added 5 commits January 17, 2023 18:42
@appendixshuffle appendixshuffle marked this pull request as ready for review January 18, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant