Fix: Estimated cost based on TX and not hardcoded value #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly simplify the logic on instance delete using error hadnling change in PR
Related ClickUp, GitHub or Jira tickets : ALEPH-496
Self proofreading checklist
Changes
This pull request includes updates to dependencies and error handling improvements in the
delete
function. The most important changes are listed below:Dependency Updates:
aleph-sdk-python
dependency to a specific branch1yam-fix-estimated-gas
inpyproject.toml
. (This need to be revert since it depends on it)Error Handling Improvements:
InsufficientFundsError
in thedelete
function insrc/aleph_client/commands/instance/__init__.py
.How to test
Explain how to test your PR.
This PR can be tested by using empty wallet with not enough gas / aleph otken
Notes
No change is made on instance create for UX reason we keep the pre check early.