Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goal is to add Voucher into the sdk
Related ClickUp, GitHub or Jira tickets : ALEPH-XXX
Self proofreading checklist
Changes
This pull request introduces significant enhancements to the Aleph SDK, primarily focusing on voucher management, including support for EVM and Solana vouchers, as well as improvements to address resolution and metadata handling. Additionally, it includes updates to typing and configuration settings to support these new features.
Voucher Management Enhancements:
AuthenticatedAlephClient
andAlephHttpClient
to retrieve vouchers (get_vouchers
,get_evm_vouchers
,get_solana_vouchers
) for EVM and Solana chains, along with helper methods for fetching voucher updates and metadata. [1] [2]src/aleph/sdk/types.py
forVoucher
,VoucherMetadata
, andVoucherAttribute
to represent voucher-related data.Address Resolution:
_resolve_address
methods to handle address resolution with fallback to the account's address if none is provided. [1] [2]Configuration Updates:
VOUCHER_METDATA_TEMPLATE_URL
,VOUCHER_SOL_REGISTRY
,VOUCHER_SENDER
) insrc/aleph/sdk/conf.py
to support voucher metadata and Solana registry integration.Typing Improvements:
overload
andoverride
for enhanced type checking and method overriding. [1] [2]src/aleph/sdk/types.py
to includeUnion
andDecimal
for voucher attributes.These changes collectively enhance the SDK's functionality for interacting with blockchain-based vouchers while improving type safety and configurability.