Code

Refactor AlephClient classes#65

Code

Merged

hoh merged 6 commits intomainaleph-im/aleph-sdk-python:mainfrom

mhh-base-client-0.8.0-alpha.1aleph-im/aleph-sdk-python:mhh-base-client-0.8.0-alpha.1Copy head branch name to clipboard

Oct 23, 2023

Commits

Commits on Oct 23, 2023

• Refactor: Duplication in parameters across get_messages and get_posts methods; Client classes are bloated and have unused parameters

  Show description for bb208e7
  MHHukiewitz

  committed
  bb208e7

  Copy full SHA for bb208e7

• Fix: Integration tests fail after changes to client and node behavior; aggregate fetching could result in unhandled parsing errors

  Show description for 347b0e2
  MHHukiewitz

  committed
  347b0e2

  Copy full SHA for 347b0e2

• Refactor: client.py became too large/difficult to understand; .py files and their contained functions did not correspond to another

  Show description for b66993a
  MHHukiewitz

  committed
  b66993a

  Copy full SHA for b66993a

• Optimization: Unnecessary class instantiation and method calls could slow down performance

  Show description for bc12555
  MHHukiewitz

  committed
  bc12555

  Copy full SHA for bc12555

• Remove/Refactor: Hacky code for sync clients is hard to maintain; models module is too broad of a name; client module classes had unclear naming

  Show description for a81e151
  

  hoh

  authored and

  MHHukiewitz

  committed
  a81e151

  Copy full SHA for a81e151

• Fix: /examples directory was unmaintained and did not work correctly

  Show description for df26946
  MHHukiewitz

  committed
  df26946

  Copy full SHA for df26946