-
Notifications
You must be signed in to change notification settings - Fork 495
p2p: reduce severity of failed capabilities advertisement #6318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
algorandskiy
merged 2 commits into
algorand:master
from
algorandskiy:pavel/p2p-cap-adv1
May 15, 2025
Merged
p2p: reduce severity of failed capabilities advertisement #6318
algorandskiy
merged 2 commits into
algorand:master
from
algorandskiy:pavel/p2p-cap-adv1
May 15, 2025
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
reviewed
May 9, 2025
2b89def
to
67f5be4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6318 +/- ##
==========================================
- Coverage 51.84% 51.81% -0.03%
==========================================
Files 652 652
Lines 87442 87446 +4
==========================================
- Hits 45331 45314 -17
- Misses 39244 39263 +19
- Partials 2867 2869 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmalouf
reviewed
May 10, 2025
gmalouf
reviewed
May 10, 2025
gmalouf
approved these changes
May 13, 2025
jannotti
approved these changes
May 15, 2025
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We observe quite a lot of messages
failed to advertise for capability gossip: context deadline exceeded
in telemetry.From DHT source code it is not quite clear where the
context.DeadlineExceeded
returned from - from finding peers or from sending to some particular peer.It looks more probable tho it could fetch some peers and attempts to send out capabilities. Following this assumption, this PR increases probability of advertising more by shuffling capabilities array before re-attempt. It also looks like the 10s repeat timeout is too short, so increased to 100s.
Test Plan
Existing tests