refactor(interactive): Support complex graph schema #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e labels Committed-by: [email protected] from Dev container Committed-by: [email protected] from Dev container
zhanglei1949
force-pushed
the
fix-many-label
branch
from
695ef6b to
95ac50b
Compare
zhanglei1949
commented
Feb 28, 2025
| edge_label_num_ = graph.schema().edge_label_num(); | ||
| vertex_label_num_ = graph.schema().vertex_label_num(); | ||
| indexs.resize(2 * vertex_label_num_ * vertex_label_num_ * edge_label_num_, |
There was a problem hiding this comment.
Seems no need to resize to 2* csr_num? @liulx20
zhanglei1949
commented
Feb 28, 2025
| @@ -88,8 +92,7 @@ class Schema { | |||
| const std::vector<std::tuple<PropertyType, std::string, size_t>>& | |||
| primary_key, | |||
| const std::vector<StorageStrategy>& strategies = {}, | |||
| size_t max_vnum = static_cast<size_t>(1) << 32, | |||
| const std::string& description = ""); | |||
| size_t max_vnum = DEFAULT_MAX_VNUM, const std::string& description = ""); | |||
There was a problem hiding this comment.
previous 2^32 is two large when we have many kind of vertices. @liulx20
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4538 +/- ##
==========================================
+ Coverage 35.01% 44.76% +9.74%
==========================================
Files 127 12 -115
Lines 13299 592 -12707
==========================================
- Hits 4657 265 -4392
+ Misses 8642 327 -8315 see 115 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
zhanglei1949
requested review from
liulx20 and
luoxiaojian
and removed request for
liulx20
liulx20
reviewed
Mar 3, 2025
|
Please check the preview of the documentation changes at |
liulx20
reviewed
Mar 3, 2025
Committed-by: xiaolei.zl from Dev container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only allow less than 256 labels for vertices and edges in Interactive. In this PR, we make
label_tcustomizable when building. And we introduce a test case to test interactive on a graph with 1000 vertex labels and 1000 edge labels.edge_triplet_id