[ISSUE #9308]For the orchestration of configuration filters, there are the following areas that can be optimized #9309 #9310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLFutureX
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9310 +/- ##
=============================================
+ Coverage 44.10% 44.12% +0.01%
- Complexity 4862 4866 +4
=============================================
Files 913 913
Lines 33052 33057 +5
Branches 3828 3828
=============================================
+ Hits 14579 14587 +8
- Misses 17052 17053 +1
+ Partials 1421 1417 -4
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Can you discuss with communities first? |
Yes, I have already raised the corresponding issue, welcome to discuss together |
|
good |
Ali786saqi
approved these changes
Dec 23, 2023
|
Preparing review... |
3 similar comments
|
Preparing review... |
|
Preparing review... |
|
Preparing review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Add FilterChainNode as the responsibility chain node to package the configuration filter, so each node contains the current configuration filter and the next responsibility chain node.
2 At startup, build a chain of responsibility through the buildConfigFilterChain() method.
3 Create EmptyFilterChainNode as the last node on the chain to reduce the next == null judgment during execution
1 新增FilterChainNode作为责任链节点，对配置过滤器进行包装，于是每个节点包含当前的配置过滤器，以及下一个责任链节点。
2 在启动时，通过buildConfigFilterChain()方法构建责任链。
3 创建EmptyFilterChainNode作为链上的最后一个节点，减少在执行过程中的 next == null 判断
issue