-
Notifications
You must be signed in to change notification settings - Fork 20
Add support for dump CLI extra parameters #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 446 474 +28
Branches 91 97 +6
=====================================
+ Hits 446 474 +28
Continue to review full report at Codecov.
|
Add support for defining extra parameters to pass to the dump CLI tool, for both the pg_dump and mysqldump Resolves #22
7e9308b
to
37be155
Compare
Why don't you just make |
@suutari-ai there might be cases where you don't want to do that, e.g. with MyISAM engine based databases. Additionally I think this is more future proof in case there's other flags that might need to be set. |
Added the |
Include the --single-transaction mysqldump parameter by default in the configuration object, but allow it to be removed if the extra parameters are defined on the configuration file explicitly. Related to #22
4d137bc
to
c9fb408
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I guess it's good that this can be configured, after all. As long as the defaults are good too, as they are now.
Nice work! 👍
Add support for defining extra parameters to pass to the dump CLI tool, for
both the pg_dump and mysqldump
Resolves #22