-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore(*): get rid of Bower in favor of Yarn aliases & checked-in packages #16385
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,7 +95,7 @@ You can mention him in the relevant thread like this: `@btford`. | |
|
||
> Thanks for submitting this issue! | ||
> Unfortunately, we don't think this functionality belongs in core. | ||
> The good news is that you could easily implement this as a third-party module and publish it on Bower and/or to the npm repository. | ||
> The good news is that you could easily implement this as a third-party module and publish it to the npm registry. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this change? It is about other people publishing to bower. Not us using dependencies from bower. Or are you just trying to move everyone away from bower in every possible way? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I guess I should revert this change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's okay to make this change. bower has no immediate advantages over npm, and is getting less important every week. |
||
|
||
|
||
## Assigning Work | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
// Override me with ?jquery=/bower_components/jquery/dist/jquery.js | ||
// Override me with ?jquery=/node_modules/jquery/dist/jquery.js |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
// Override me with ?jquery=/bower_components/jquery/dist/jquery.js | ||
// Override me with ?jquery=/node_modules/jquery/dist/jquery.js |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
// Override me with ?jquery=/bower_components/jquery/dist/jquery.js | ||
// Override me with ?jquery=/node_modules/jquery/dist/jquery.js |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ var path = require('canonical-path'); | |
/** | ||
* dgService getVersion | ||
* @description | ||
* Find the current version of the bower component (or node module) | ||
* Find the current version of the node module | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this function is only used to get node modules (afaict it does), we can simplify the implementation and remove the second and third arguments. I think this happened already when we moved most of the bower stuff to node. |
||
*/ | ||
module.exports = function getVersion(readFilesProcessor) { | ||
var basePath = readFilesProcessor.basePath; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ var rename = require('gulp-rename'); | |
|
||
// We indicate to gulp that tasks are async by returning the stream. | ||
// Gulp can then wait for the stream to close before starting dependent tasks. | ||
// See clean and bower for async tasks, and see assets and doc-gen for dependent tasks below | ||
// See clean for an async task, and see assets and doc-gen for dependent tasks below. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Neither |
||
|
||
var outputFolder = '../build/docs'; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,6 @@ | |
"angular-benchpress": "0.x.x", | ||
"benchmark": "1.x.x", | ||
"bootstrap": "3.1.1", | ||
"bower": "~1.3.9", | ||
"browserstacktunnel-wrapper": "2.0.0", | ||
"canonical-path": "0.0.2", | ||
"changez": "^2.1.1", | ||
|
@@ -60,7 +59,9 @@ | |
"jasmine-core": "2.5.2", | ||
"jasmine-node": "^2.0.0", | ||
"jasmine-reporters": "^2.2.0", | ||
"jquery": "^3.2.1", | ||
"jquery": "3.2.1", | ||
"jquery-2.1": "npm:[email protected]", | ||
"jquery-2.2": "npm:[email protected]", | ||
"karma": "^1.7.0", | ||
"karma-browserstack-launcher": "^1.2.0", | ||
"karma-chrome-launcher": "^2.1.1", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what changed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new line was added to the end of the file.