Skip to content

🧪 Pre-build armv7l images for building wheels #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: devel
Choose a base branch
from

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented May 9, 2025

These are relatively recent upstream and only exist for glibc 2.31.

SUMMARY

$sbj.

ISSUE TYPE
  • Maintenance Pull Request
  • Packaging Pull Request
ADDITIONAL INFORMATION

Blocks #648.

These are relatively recent upstream and only exist for glibc 2.31.
@webknjaz webknjaz self-assigned this May 9, 2025
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-pylibssh-719
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

alex and others added 3 commits May 9, 2025 17:46
* build armv7l images

* Update build-docker-images.yml

* Don't use `enable-ec_nistp_64_gcc_128` on armv7l

* hack?

* We are an armv4 build

(cherry picked from commit 519b16bd0803ea22dbd0a4525c641060581c0215)
@webknjaz webknjaz force-pushed the maintenance/gha-qemu-armv7l branch from 50842c9 to 1bfb53c Compare May 9, 2025 17:22
reaperhulk and others added 2 commits May 9, 2025 19:23
* openssl 3.3.2

* fix paths for mac/win as well

* vendor a patch to work around the openssl 3.3.2 perl issue

(cherry picked from commit 3a92c5cba96d920617d9c586ebc64abc96ac08ac)
@webknjaz webknjaz force-pushed the maintenance/gha-qemu-armv7l branch from 22b3e7e to 976251d Compare May 9, 2025 17:23
Copy link

sonarqubecloud bot commented May 10, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@webknjaz
Copy link
Member Author

@Jakuje any idea if it's possible to stop linking against libdl? https://github.com/ansible/pylibssh/actions/runs/14943974923/job/41986747379?pr=719#step:4:4032. Ubuntu Focal doesn't ship libdl.so.2 and the 2_31 containers (the first ones to ship armv7l) are based on it.

@Jakuje
Copy link
Contributor

Jakuje commented May 13, 2025

The libdl (dlopen, ...) is not needed directly by the libssh, but whole openssl is now based on dlopened modules (providers) so I assume this is transitive dependency.

That sounds weird that this would not be shipped in the recent ubuntu. Isn't it just somewhere else or accessible somehow differently? What were the errors you got when you tried to link with dl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants