Skip to content

feat: update with delta #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

feat: update with delta #1922

wants to merge 51 commits into from

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Apr 18, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@umutsoysalansys umutsoysalansys changed the title Feat/update with delta feat: update with delta Apr 18, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 18, 2025
@umutsoysalansys umutsoysalansys marked this pull request as ready for review June 4, 2025 14:30
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner June 4, 2025 14:30
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 36.58537% with 104 lines in your changes missing coverage. Please review.

Project coverage is 89.56%. Comparing base (c3a98ef) to head (b8cbc56).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/design.py 12.98% 67 Missing ⚠️
src/ansys/geometry/core/tools/problem_areas.py 50.00% 27 Missing ⚠️
...s/geometry/core/_grpc/_services/v0/repair_tools.py 64.70% 6 Missing ⚠️
src/ansys/geometry/core/tools/repair_tools.py 71.42% 4 Missing ⚠️

❌ Your project check has failed because the head coverage (89.56%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
- Coverage   90.45%   89.56%   -0.90%     
==========================================
  Files         136      136              
  Lines        9730     9877     +147     
==========================================
+ Hits         8801     8846      +45     
- Misses        929     1031     +102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants