-
Notifications
You must be signed in to change notification settings - Fork 19
Creating ansys.geometry.core.misc.units
submodule
#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also changing accuracy submodule to |
This PR is basically going to touch every single file... We are modifying the entire abstraction for Points and Vectors... Stay put for more news @chadqueen @jorgepiloto @MaxJPRey @Revathyvenugopal162 @akaszynski. But the upside is that we are going to refactor a lot of code (hopefully) and it is going to be more intuitive. Still working on it. Please, do not open PRs involving the math subpackage until this PR is merged (apart from #75). |
Ready to be reviewed @chadqueen @jorgepiloto @MaxJPRey @Revathyvenugopal162 and @akaszynski... A lot of refactoring has been made. And a lot of work on the abstraction layer has been put on to for the BTW, having the huge suite of tests we have was awesome to finding bugs. Keep up the good work y'all! 😄 |
Refactoring is only possible when you have solid test coverage. |
Side note: @MaxJPRey, please have a look at how we're doing units here and have it applied to PyAEDT. |
We need an |
@akaszynski Sure, I have already started to investigate how to "easily" apply it to PyAEDT and how to avoid any side effects. For sure it will be a beneficial but a significant change. @akaszynski @RobPasMue +1 for ansys.tools.units |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactoring.
Co-authored-by: Maxime Rey <[email protected]>
This module will contain:
Point
,shapes
)