Skip to content

Creating ansys.geometry.core.misc.units submodule #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Sep 10, 2022

Conversation

RobPasMue
Copy link
Member

This module will contain:

  • The base units for the PyGeometry package
  • Common functionalities for dimension-related classes (such as Point, shapes)

@RobPasMue RobPasMue linked an issue Sep 8, 2022 that may be closed by this pull request
@RobPasMue
Copy link
Member Author

Also changing accuracy submodule to misc

@github-actions github-actions bot added the enhancement New features or code improvements label Sep 8, 2022
@RobPasMue RobPasMue self-assigned this Sep 8, 2022
@RobPasMue
Copy link
Member Author

This PR is basically going to touch every single file... We are modifying the entire abstraction for Points and Vectors... Stay put for more news @chadqueen @jorgepiloto @MaxJPRey @Revathyvenugopal162 @akaszynski.

But the upside is that we are going to refactor a lot of code (hopefully) and it is going to be more intuitive.

Still working on it. Please, do not open PRs involving the math subpackage until this PR is merged (apart from #75).

@RobPasMue RobPasMue linked an issue Sep 9, 2022 that may be closed by this pull request
@RobPasMue RobPasMue marked this pull request as ready for review September 9, 2022 14:54
@RobPasMue RobPasMue requested review from chadqueen and removed request for chadqueen September 9, 2022 14:54
@RobPasMue
Copy link
Member Author

Ready to be reviewed @chadqueen @jorgepiloto @MaxJPRey @Revathyvenugopal162 and @akaszynski... A lot of refactoring has been made. And a lot of work on the abstraction layer has been put on to for the math subpackage.

BTW, having the huge suite of tests we have was awesome to finding bugs. Keep up the good work y'all! 😄

@RobPasMue RobPasMue requested a review from chadqueen September 9, 2022 15:10
@akaszynski
Copy link
Contributor

having the huge suite of tests we have was awesome to finding bugs

Refactoring is only possible when you have solid test coverage.

@akaszynski
Copy link
Contributor

Side note: @MaxJPRey, please have a look at how we're doing units here and have it applied to PyAEDT.

@RobPasMue
Copy link
Member Author

Side note: @MaxJPRey, please have a look at how we're doing units here and have it applied to PyAEDT.

If you find anything reusable @MaxJPRey that we may want to generalize for all PyAnsys libraries let me know. We can work on creating a new tools package for this.

@akaszynski
Copy link
Contributor

Side note: @MaxJPRey, please have a look at how we're doing units here and have it applied to PyAEDT.

If you find anything reusable @MaxJPRey that we may want to generalize for all PyAnsys libraries let me know. We can work on creating a new tools package for this.

We need an ansys.tools.units package (or helpers, whatever we're using today). First let's get this library working, next is get PyAEDT to adopt pint, third is the common package.

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Sep 9, 2022

Side note: @MaxJPRey, please have a look at how we're doing units here and have it applied to PyAEDT.

@akaszynski Sure, I have already started to investigate how to "easily" apply it to PyAEDT and how to avoid any side effects. For sure it will be a beneficial but a significant change.

@akaszynski @RobPasMue +1 for ansys.tools.units

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring.

@RobPasMue RobPasMue enabled auto-merge (squash) September 10, 2022 07:22
@RobPasMue RobPasMue merged commit bd48b7b into main Sep 10, 2022
@RobPasMue RobPasMue deleted the feat/refactor-units-code branch September 10, 2022 07:34
@RobPasMue RobPasMue linked an issue Sep 13, 2022 that may be closed by this pull request
@RobPasMue RobPasMue linked an issue Oct 21, 2022 that may be closed by this pull request
5 tasks
@RobPasMue RobPasMue removed a link to an issue Oct 21, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero vector should be accepted Check shape signatures consistency Refactor classes to avoid code duplication: Units scope
4 participants