Skip to content

FIX: Pin name #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

FIX: Pin name #1235

wants to merge 14 commits into from

Conversation

gkorompi
Copy link
Collaborator

No description provided.

@gkorompi gkorompi requested a review from svandenb-dev May 20, 2025 12:56
@gkorompi gkorompi changed the title Pin name FIX: Pin name May 20, 2025
@gkorompi gkorompi linked an issue May 20, 2025 that may be closed by this pull request
@gkorompi gkorompi enabled auto-merge (squash) May 20, 2025 12:58
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I can't approve this PR I had the same discussion yesterday with @hui-zhou-a as I wanted to do the exact same changes to be compliant with grpc. grpc version is doing like your changes.

@hui-zhou-a hui-zhou-a closed this May 23, 2025
auto-merge was automatically disabled May 23, 2025 20:45

Pull request was closed

@hui-zhou-a
Copy link
Collaborator

hui-zhou-a commented May 23, 2025

Fixed in #1262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get same pin.name on grpc and dotnet
3 participants