Skip to content

FIX: Multi freq #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 26, 2025
Merged

FIX: Multi freq #1238

merged 21 commits into from
May 26, 2025

Conversation

gkorompi
Copy link
Collaborator

@gkorompi gkorompi commented May 20, 2025

Multi frequency setup fix, as it was including only one freq
closing #188

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (3f48c24) to head (9a50fff).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1238      +/-   ##
==========================================
- Coverage   76.75%   76.73%   -0.03%     
==========================================
  Files         163      163              
  Lines       24129    24134       +5     
==========================================
- Hits        18520    18519       -1     
- Misses       5609     5615       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@gkorompi gkorompi requested a review from svandenb-dev May 22, 2025 18:11
@github-actions github-actions bot added the testing Anything related to testing label May 22, 2025
@gkorompi
Copy link
Collaborator Author

Please add a test

Added test for all cases (single,broadband,multi)

@gkorompi gkorompi enabled auto-merge (squash) May 22, 2025 18:11
@gkorompi gkorompi requested a review from hui-zhou-a May 24, 2025 04:55
svandenb-dev
svandenb-dev previously approved these changes May 26, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkorompi gkorompi merged commit 256e434 into main May 26, 2025
20 checks passed
@gkorompi gkorompi deleted the multi_freq branch May 26, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In edb Method set_solution_multi_frequencies() not working as expected
3 participants