Skip to content

FIX: distributed coax port #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/pyedb/configuration/cfg_ports_sources.py
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,11 @@ def create_terminals(self):
pos_coor_terminal = dict()
if self.type == "coax":
pins = self._get_pins(pos_type, pos_value, self.positive_terminal_info.reference_designator)
pins = {f"{self.name}_{self.positive_terminal_info.reference_designator}": i for _, i in pins.items()}
if len(pins) < 2:
pins = {f"{self.name}": i for _, i in pins.items()}
else:
pins = {f"{self.name}_{name}": i for name, i in pins.items()}
self.distributed = True
pos_objs.update(pins)
elif pos_type == "coordinates":
layer = self.positive_terminal_info.layer
Expand Down
10 changes: 10 additions & 0 deletions tests/legacy/system/test_edb_configuration_2p0.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,13 +355,23 @@ def test_05b_ports_coax(self, edb_examples):
"type": "coax",
"positive_terminal": {"net": "PCIe_Gen4_TX2_CAP_N"},
},
{
"name": "coax",
"reference_designator": "X1",
"type": "coax",
"positive_terminal": {"net": "5V"},
},
]
data = {"ports": ports}
edbapp = edb_examples.get_si_verse()
assert edbapp.configuration.load(data, apply_file=True)
assert edbapp.ports["COAX_U1_AM17"]
assert edbapp.ports["COAX_U1_PCIe_Gen4_TX2_CAP_N"]
assert edbapp.ports["COAX_U1_PCIe_Gen4_TX2_CAP_N"].location
assert edbapp.ports["coax_X1_5V_B18"]
assert edbapp.ports["coax_X1_5V_B17"]
assert edbapp.ports["coax_X1_5V_A18"]
assert edbapp.ports["coax_X1_5V_A17"]
edbapp.close()

def test_05c_ports_circuit_pin_net(self, edb_examples):
Expand Down
Loading