Skip to content

chore: Add a way to extract Fluent launch command and subprocess arguments from StandaloneLauncher #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented May 16, 2025

import subprocess
from ansys.fluent.core.launcher.standalone_launcher import StandaloneLauncher
launcher = StandaloneLauncher(ui_mode="gui", dimension=2)
subprocess.run(launcher.command, **launcher.subprocess_keywords)

@github-actions github-actions bot added the enhancement Improve any current implemented feature label May 16, 2025
Comment on lines +251 to +260
@property
def command(self) -> str:
"""Return the command for launching Fluent."""
return self._launch_string

@property
def subprocess_keywords(self) -> dict[str, Any]:
"""Return the keyword arguments for launching Fluent via Python subprocess."""
return self._kwargs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we going to use this information ? Does it require for the standalone mode only ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, a similar question in the same line, why not for container launcher as well?

@seanpearsonuk
Copy link
Collaborator

@mkundu1 I would prefer to create a DetachedLauncher class. The absolutely simplest implementation would just wrap the code you showed in the description. A more elaborate design would use a new shared base class, which would need to expose launcher.command and launcher.subprocess_keywords to subclasses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants