chore: Update settings_builtin_data.py to 26.1 #4064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
seanpearsonuk,
prmukherj and
hpohekar
as code owners
mkundu1
force-pushed
the
chore/update_settings_builtin_data
branch
from
64e078b to
84b60d7
Compare
mkundu1
commented
May 24, 2025
There was a problem hiding this comment.
@prmukherj The CI is currently failing because we have pushed a 26.1 image as a stable image. The following CI changes should fix the issue. This is a safe change as 25.2 image is now frozen, so we don't expect any regression for not using the stable image.
There was a problem hiding this comment.
I have pulled the settings_builtin_data chenges into the other PR. So it should be fine now. I have manually copied the changes. So, think we can remove this PR now.
Thank you for the fix.
hpohekar
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.