-
Notifications
You must be signed in to change notification settings - Fork 132
refactor: enhance error reporting in pytest output for better debugging #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideCentralize error message parsing in get_error_message and apply across pytest summary output, while extending reporting to skipped tests for improved debugging. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Rather than parsing
rep.longreprtext.splitlines()
, consider usingrep.longrepr.reprcrash.path
andrep.longrepr.reprcrash.message
for a more robust extraction of filename, line number, and error message. - The inline
get_error_message
function could be moved out of the hook and into a shared utility to make it easier to test and reuse across other pytest hooks. - Be cautious with
ast.literal_eval
onrep.longreprtext
lines, as complex or parameterized failures might not match the expected tuple format—adding a fallback for unparsable cases would avoid exceptions in the summary.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…https://github.com/ansys/pymapdl into feat/enhance-error-reporting-in-pytest-output
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
+ Coverage 88.27% 88.34% +0.06%
==========================================
Files 187 187
Lines 14840 14906 +66
==========================================
+ Hits 13100 13168 +68
+ Misses 1740 1738 -2 🚀 New features to boost your workflow:
|
Description
As the title.
Issue linked
Spin out of #1300
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Enhance Pytest output by parsing report details to provide concise, consistent summaries of test failures, errors, and skips
Enhancements:
Tests: