Skip to content

feat: support OIDC claim validator (#8772) #11824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

beardnick
Copy link

@beardnick beardnick commented Dec 12, 2024

Description

Fixes #8772

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Dec 12, 2024
@bzp2010 bzp2010 self-requested a review December 19, 2024 11:08
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 26, 2025
@Baoyuantop
Copy link
Contributor

Hi @beardnick, please make the test pass

@beardnick
Copy link
Author

Hi @beardnick, please make the test pass

Ok, I'll take a look

@beardnick beardnick force-pushed the feature-oidc-validate branch from a7db44e to d53ef5e Compare March 26, 2025 13:04
@@ -317,6 +319,11 @@ local schema = {
items = {
type = "string"
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add documentation for this

@github-actions github-actions bot removed the stale label Mar 27, 2025
@Baoyuantop Baoyuantop moved this to 🏗 In progress in Apache APISIX backlog Mar 28, 2025
@Baoyuantop Baoyuantop moved this from 🏗 In progress to 👀 In review in Apache APISIX backlog Mar 28, 2025
@Baoyuantop
Copy link
Contributor

Hi @beardnick, do you have time to continue working on this PR?

@beardnick
Copy link
Author

Hi @beardnick, do you have time to continue working on this PR?

Sorry, I'm busy last few days. I'll continue work on it tomorrow.

@beardnick
Copy link
Author

@Baoyuantop I took a more detailed look at the code. Seems this pr(#11987) did something similar to my pr. Do you think my pr is still necessary?

@jmaasing
Copy link

jmaasing commented Apr 6, 2025

@Baoyuantop I took a more detailed look at the code. Seems this pr(#11987) did something similar to my pr. Do you think my pr is still necessary?

I'm not an apisix-developer but a user so I can't say anything about the implementation details. But I am looking to your PR to have the ability to configure the plugin to only allow requests through if the user has a "roles" claim containing one or more specific roles.

The PR you are referencing seems similar but geared towards checking the 'aud' claim only, which is nice but does not cover my use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: 👀 In review
3 participants