-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: support OIDC claim validator (#8772) #11824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
Hi @beardnick, please make the test pass |
Ok, I'll take a look |
a7db44e
to
d53ef5e
Compare
@@ -317,6 +319,11 @@ local schema = { | |||
items = { | |||
type = "string" | |||
} | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add documentation for this
Hi @beardnick, do you have time to continue working on this PR? |
Sorry, I'm busy last few days. I'll continue work on it tomorrow. |
@Baoyuantop I took a more detailed look at the code. Seems this pr(#11987) did something similar to my pr. Do you think my pr is still necessary? |
I'm not an apisix-developer but a user so I can't say anything about the implementation details. But I am looking to your PR to have the ability to configure the plugin to only allow requests through if the user has a "roles" claim containing one or more specific roles. The PR you are referencing seems similar but geared towards checking the 'aud' claim only, which is nice but does not cover my use case. |
Description
Fixes #8772
Checklist