Skip to content

fix: memory leak when handling large resp body #12035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@membphis
Copy link
Member

membphis commented Apr 3, 2025

@shreemaan-abhishek

Is this task still ongoing? If not, we can close it ^_^

@shreemaan-abhishek
Copy link
Contributor Author

@membphis, yes I still want to work on it, I am unable to repro the bug right now 😂.

In theory, the memory leak still exists, the method of body chunk collection is wrong, and can lead to memory leak.

check: openresty/lua-nginx-module#2346

@membphis
Copy link
Member

I can sure this is not a memory leak case

the memory was cache to the dlmalloc, It does not release the memory immediately.

@membphis membphis closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants