-
Notifications
You must be signed in to change notification settings - Fork 927
Split most arrow specific CI checks into their own workflows (reduce common CI time to 21 minutes) #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2168 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 237 237
Lines 61429 61429
=======================================
+ Hits 50902 50903 +1
+ Misses 10527 10526 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tall pole is still the "Test" job but now it takes 21 minutes 🥳 🦜 https://github.com/apache/arrow-rs/runs/7510812685?check_suite_focus=true
uses: ./.github/actions/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Test default features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these tests are moved from the main Rust.yml test
omnibus test
- name: Check compilation with simd features | ||
run: | | ||
cargo check -p arrow --features simd | ||
cargo check -p arrow --features simd --all-targets | ||
|
||
windows-and-macos: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not quite sure what to do with windows and mac which run in the Rust
workflow now -- I am thinking perhaps I could change the CI to run just the jobs for each crate individually for mac 🤔
@@ -54,25 +54,6 @@ jobs: | |||
run: | | |||
# run tests on all workspace members with default feature list | |||
cargo test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically speaking this still runs tests for arrow in the main rust flow as well -- I plan to remove this over time
We are slowly getting there -- thanks @viirya |
Benchmark runs are scheduled for baseline = 0c64054 and contender = e96ae8a. e96ae8a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Re #2149
Rationale for this change
Breaking up the CI for each crate into more finegrained workflows is a prerequisite for triggering in a more finegrained way (e.g. not run arrow tests if only parquet is changed)
More rationale os #2149
What changes are included in this PR?
Break arrow specific CI checks into a new
arrow.yml
workflow. It is still triggered on all PRsAre there any user-facing changes?
There will be more Ci jobs, but hopefully they will each run in less time