Parquet: don't truncate f16/decimal min/max stats #5154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference parquet-mr has similar logic, difference being instead of opting out of truncation for Decimal, they enforce that types need to opt-in: Which has similar effect in ensuring Decimal isn't truncated (Float16 support isn't yet merged in for parquet-mr, but they aren't changing that logic in the Float16 PR so presumably will also not do truncation: apache/parquet-java#1142) |
tustvold
approved these changes
Dec 5, 2023
Those were the only places that called the truncate min/max functions |
|
What about in write_column_metadata? |
Jefffrey
commented
Dec 5, 2023
Comment on lines
+967
to
+969
| Statistics::FixedLenByteArray(stats) | ||
| if (stats.has_min_max_set() && self.can_truncate_value()) => | ||
| { |
There was a problem hiding this comment.
What about in write_column_metadata?
This covers the truncation in write_column_metadata(..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5075
Rationale for this change
All logical types with
BYTE_ARRAY/FIXED_LEN_BYTE_ARRAYunderlying physical types share the sort order as their physical type, that being unsigned byte-wise comparison, except forFloat16andDecimal. Applying the truncation logic to their min/max statistics can therefore lead to inaccurate statistics.What changes are included in this PR?
Add check before truncating min/max statistics to ensure
DecimalandFloat16columns don't get truncated.Are there any user-facing changes?