DataFusion 16.0.0 documentation #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 22, 2023
There was a problem hiding this comment.
Thanks @andygrove
This reminds me we could/should probably work on updating the documentation more. I have it on my wishlist and will work on it when I have time.
4 tasks
DDtKey
reviewed
Jan 22, 2023
Comment on lines
+329
to
+332
| <tr class="row-even"><td><p>datafusion.catalog.create_default_catalog_and_schema</p></td> | ||
| <td><p>true</p></td> | ||
| <td><p>Number of partitions for query execution. Increasing partitions can increase concurrency. Defaults to the number of cpu cores on the system.</p></td> | ||
| </tr> |
There was a problem hiding this comment.
Is that correct statement? Looks wrong 🤔
Description the same with datafusion.execution.target_partitions
There was a problem hiding this comment.
It sure looks incorrect to me. I think it is an issue upstream: https://github.com/apache/arrow-datafusion/blob/5d4038a8463a575328bedbc22b32456f5dcd562c/datafusion/common/src/config.rs#L157-L158
Nice catch @DDtKey -- I'll make a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related apache/datafusion#4776