Skip to content

fix: apply repositories.gradle for cordova.gradle dependencies #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 23, 2025

Motivation and Context

Resolves #1759

Use repos defined in repositories.gradle for the cordova.gradle dependencies

Description

Replaced:

repositories {
    google()
    mavenCentral()
}

With:

apply from: 'repositories.gradle'
repositories repos

Testing

  • npm t
  • Created and built sample Cordova app with changes

Checklist

  • I've run the tests to see all new and existing tests pass
  • Updated automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.12%. Comparing base (f0e8885) to head (6d01432).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          23       23           
  Lines        1844     1844           
=======================================
  Hits         1330     1330           
  Misses        514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu added this to the 15.0.0 milestone Jun 23, 2025
@erisu erisu requested a review from breautek June 24, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue resolving the dependency io.github.g00fy2:versioncompare:1.4.1@jar mentioned in cordova.gradle
2 participants