Skip to content

[WIP] Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR config #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 13, 2025

Which issue does this PR close?

Closes #1254

Rationale for this change

The config COMET_SHUFFLE_FALLBACK_TO_COLUMNAR was added as a workaround for Spark SQL test failures and we need to remove it since users could run into the same bugs that is causing the Spark SQL failures.

What changes are included in this PR?

  • Remove config
  • Fix Spark SQL test failures:

core1

  • test with low buffer spill threshold
  • SPARK-32038: NormalizeFloatingNumbers should work on distinct aggregate
  • reverse preceding/following range between with aggregation

core2

  • subquery/exists-subquery/exists-orderby-limit.sql

core3

  • SPARK-32649: Optimize BHJ/SHJ inner/semi join with empty hashed relation
  • SPARK-38237: require all cluster keys for child required distribution for window query

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.66%. Comparing base (f09f8af) to head (b3cf832).
Report is 195 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1736      +/-   ##
============================================
+ Coverage     56.12%   58.66%   +2.53%     
- Complexity      976     1138     +162     
============================================
  Files           119      129      +10     
  Lines         11743    12684     +941     
  Branches       2251     2372     +121     
============================================
+ Hits           6591     7441     +850     
- Misses         4012     4058      +46     
- Partials       1140     1185      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR config
2 participants