-
Notifications
You must be signed in to change notification settings - Fork 204
fix: [native_iceberg_compat / native_datafusion] Fall back to Spark for maps containing structs #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @andygrove
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1764 +/- ##
============================================
+ Coverage 56.12% 58.62% +2.49%
- Complexity 976 1138 +162
============================================
Files 119 130 +11
Lines 11743 12671 +928
Branches 2251 2367 +116
============================================
+ Hits 6591 7428 +837
- Misses 4012 4058 +46
- Partials 1140 1185 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
// https://github.com/apache/datafusion-comet/issues/1754 | ||
ignore("native reader - read MAP of value STRUCT fields") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we are doing the data type support check for maps of struct. Dow we still have to ignore these tests?
If so, is there a way to ignore only for native datafusion/iceberg-compat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test suite is specific to native datafusion/iceberg-compat scans. The fallback is just a temporary workaround until we have the real fix for #1754, then we can re-enable these tests.
One test keeps failing without any actual test failures. This is happening on other PRs as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending with CI
Moving this to draft because we may want to merge #1771 instead |
Which issue does this PR close?
Workaround for #1754
Rationale for this change
Fix the following Spark SQL tests in
core-2
.What changes are included in this PR?
How are these changes tested?