Skip to content

Fix CASE expression spans #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025
Merged

Conversation

eliaperantoni
Copy link
Contributor

Previously, a Expr::Case implementation of Spanned would ignore the CASE .. END keywords. ie.

CASE a WHEN b THEN c ELSE d END
--   ^^^^^^^^^^^^^^^^^^^^^^
--   Only this would be highlighted

Because the only stored locations would be those of the Ident inside the CASE expression.

This PR attaches two AttachedToken to the AST node, one for CASE and one for END, so that Spanned::span now returns the whole range. This was done to follow the footsteps of the SELECT implementation, which also stores an AttachedToken for the SELECT keyword. Also added a test for this.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eliaperantoni! The changes look reasonable to me, left a minor comment

@eliaperantoni eliaperantoni requested a review from iffyio June 6, 2025 12:47
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again @eliaperantoni!
cc @alamb

@iffyio iffyio merged commit ff29dd2 into apache:main Jun 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants