-
Notifications
You must be signed in to change notification settings - Fork 612
Store keywords in enum ~2x perf. improvement #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
959e9d0
Store keywords in enum
Dandandan b42e103
Finalize conversion
Dandandan 547a6da
Fix RESERVED_FOR_COLUMN_ALIAS
Dandandan 582ca86
Fix last tests
Dandandan 46f88c5
Handle other tables in same way
Dandandan 6afcbeb
Fix style issue
Dandandan 2f85180
Fix style issue
Dandandan 4884156
Fix format issue
Dandandan 4c793b9
Merge changes with master, add Keyword::NoKeyword
Dandandan 3dd467a
Remove explicit clones
Dandandan ca3c10d
Remove reduntant clones
Dandandan df6d60d
Remove reduntant clones
Dandandan b16c17b
Address review comments, do not use ::parse but create normal parse f…
Dandandan b03f475
Group together related keywords
Dandandan 14da209
Fix Range -> Groups
Dandandan 6ac8879
Add a test to ensure GROUPS in window specification round-trips
nickolay fea2f91
Change the order in RESERVED_FOR_... keyword lists to match
nickolay b551997
Avoid unnecessary wildcard imports in tests
nickolay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.