Move aggregate statistic , combine aggregate and limited distinct aggregate test to slt #10554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
core
jayzhan211
commented
May 17, 2024
| )?; | ||
|
|
||
| // We introduce an intermediate optimization step between the partial and final aggregtator | ||
| let coalesce = CoalescePartitionsExec::new(Arc::new(partial_agg)); |
There was a problem hiding this comment.
Since the optimized code does not have specific behavior on the non-indirect plan, I think the test is not necessary
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
changed the title
jayzhan211
changed the title
jayzhan211
commented
May 17, 2024
| } | ||
|
|
||
| #[test] | ||
| fn aggregations_with_group_combined() -> Result<()> { |
There was a problem hiding this comment.
group by and limit tests are not ported because I didn't find a query that has a result of combine aggregate.
But I think it is fine because there is at least one query that covers the test of optimization here, and there is no specific optimization based on group by or limit.
|
I think I can use functions-aggregate in physical optimizer directly 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10384
Rationale for this change
There are some tests that use AggregateExpr::Count directly, which makes it difficult for #10484
Move all test that has
AggregateExprto slt if possible.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?